Merge lp://staging/~mvo/pkgme/not-native-by-default into lp://staging/pkgme

Proposed by Michael Vogt
Status: Superseded
Proposed branch: lp://staging/~mvo/pkgme/not-native-by-default
Merge into: lp://staging/pkgme
Diff against target: 155 lines (+75/-4)
6 files modified
pkgme/bin/main.py (+5/-1)
pkgme/debuild.py (+28/-0)
pkgme/package_files.py (+1/-1)
pkgme/tests/test_debuild.py (+38/-0)
pkgme/tests/test_package_files.py (+1/-1)
pkgme/tests/test_script.py (+2/-1)
To merge this branch: bzr merge lp://staging/~mvo/pkgme/not-native-by-default
Reviewer Review Type Date Requested Status
Michael Vogt (community) Needs Resubmitting
Jonathan Lange Approve
Review via email: mp+115805@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2012-07-20.

Commit message

Make non-native packages by default.

Description of the change

This branch make pkgme create non-native branches by default.

The reason I suggest this is:
- Its conceptually cleaner to split the package into the orig and the debian part. Now that is not very relevant.
- If the packaging needs tweaking or updating this way the packager just needs to update and upload debian changes instead of the entire package. For large packages this is a significant win. This will not be relevant anymore when pkgme is perfect.

This is a modified version of the previous version that avoids breaking pkgme-service by making build_orig_tar_gz part of build_source_package.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

<mvo> james_w: cool, so test+docstring+better place and we are good to go?
<james_w> mvo, I think so

I will work on this tomorrow morning.

review: Needs Fixing
Revision history for this message
Michael Vogt (mvo) wrote :

I added a docstring and a (functional) test now. I also switched from source format 1.0 back to 3.0, but quilt this time. Please have a look at let me know what you think.

Revision history for this message
Jonathan Lange (jml) wrote :

Code looks great, and thanks to your update I understand why we want to do this. Thank you!

review: Approve
Revision history for this message
Michael Vogt (mvo) wrote :

After merging this broke the world^Wpkgme-service I modified it so that now build_orig_tar_gz() run as part of build_source_package() which is ok I think. Alternatively I can change pkgme-service if that is a preferable way to fix this problem.

review: Needs Resubmitting
126. By Michael Vogt

merge trunk

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: