Merge lp://staging/~mvo/piston-mini-client/proxy_type_http_no_tunnel into lp://staging/piston-mini-client

Proposed by Michael Vogt
Status: Merged
Merged at revision: 48
Proposed branch: lp://staging/~mvo/piston-mini-client/proxy_type_http_no_tunnel
Merge into: lp://staging/piston-mini-client
Diff against target: 170 lines (+82/-10)
3 files modified
piston_mini_client/__init__.py (+17/-6)
piston_mini_client/socks.py (+59/-4)
piston_mini_client/tests/test_proxy.py (+6/-0)
To merge this branch: bzr merge lp://staging/~mvo/piston-mini-client/proxy_type_http_no_tunnel
Reviewer Review Type Date Requested Status
Anthony Lenton Approve
Review via email: mp+78094@code.staging.launchpad.net

Description of the change

This adds support for a new type of http proxy that is sufficient for plain http tunneling to the internals version of socks.py. It will also patch httplib2 to use the internal version of socks.py over the one bundled with httplib2 that has no support for this. See http://code.google.com/p/httplib2/issues/detail?id=38 for some more details

To post a comment you must log in.
53. By Michael Vogt

piston_mini_client/__init__.py: always import httplib2 first

54. By Michael Vogt

use logging.warn() instead of print

Revision history for this message
Anthony Lenton (elachuni) wrote :

Thanks for the fix mvo!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches