Core Snap

Merge lp://staging/~mvo/core-snap/detect-core-support into lp://staging/core-snap

  1. detect-core-support
  2. Merge into trunk
Proposed by Michael Vogt
Status: Needs review
Proposed branch: lp://staging/~mvo/core-snap/detect-core-support
Merge into: lp://staging/core-snap
Diff against target: 18 lines (+6/-1)
1 file modified
hooks/configure (+6/-1)
To merge this branch: bzr merge lp://staging/~mvo/core-snap/detect-core-support
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Disapprove
Review via email: mp+317773@code.staging.launchpad.net

Description of the change

This branch adds support to detect if we have the "core-support" interface available. If the interface is not available the hook will simply do nothing.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good to me, just one question.

(and yes, I'd love if we could petsit)

review: Approve
Reply
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

LGTM

Reply
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good but let's please land it to github.com/snapcore/core now as that's where we pick up core builds into the store.

review: Disapprove
Reply

Unmerged revisions

55. By Michael Vogt

hooks/configure: ignore systems that have no core-support activated

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches