click

Merge lp://staging/~mvo/click/lp1319790-chroot-fstab into lp://staging/click

  1. lp1319790-chroot-fstab
  2. Merge into trunk
Proposed by Michael Vogt
Status: Needs review
Proposed branch: lp://staging/~mvo/click/lp1319790-chroot-fstab
Merge into: lp://staging/click
Diff against target: 139 lines (+29/-20)
6 files modified
Makefile.am (+1/-1)
click/chroot.py (+25/-1)
click/commands/chroot.py (+1/-2)
click/tests/test_chroot.py (+2/-1)
schroot/Makefile.am (+0/-3)
schroot/fstab (+0/-12)
To merge this branch: bzr merge lp://staging/~mvo/click/lp1319790-chroot-fstab
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
click hackers Pending
Review via email: mp+219728@code.staging.launchpad.net

Description of the change

This branch may be a bit controversial, not sure. I ran into the issue that my $HOME is not on /home but instead on /space/home. This branch generates the fstab for the schroot more dynamically so that this case is taken into account.

However the autogeneration isn't exactly dynamic as its only done on create and AIUI the other commands do not require root so we can't easily update. So the branch helps but ideas/suggestions how to auto-generate fstab on each schroot command would be great.

Thanks,
 Michael

To post a comment you must log in.
lp://staging/~mvo/click/lp1319790-chroot-fstab updated
427. By Michael Vogt

click/commands/chroot.py: remove check for /etc/schroot/click/fstab. the fstab is auto-generated now

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:427
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mvo/click/lp1319790-chroot-fstab/+merge/219728/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/click-ci/2/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/click-utopic-amd64-ci/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/2/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-ci/2/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:427
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mvo/click/lp1319790-chroot-fstab/+merge/219728/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/click-ci/4/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/click-utopic-amd64-ci/4/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/4/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-ci/4/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Can this see work to get it in? See bug #1427264

Reply
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

And bug #1436835

Reply
lp://staging/~mvo/click/lp1319790-chroot-fstab updated
428. By Michael Vogt

merged lp:click/devel

429. By Michael Vogt

merged lp:click, fixes conflicts, fixed tests

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks Timo for the reminder and sorry that this was so long untouched. I updated the branch and resolved conflicts/updated tests. There is a bit of a reviewers shortage for click right now, I will try to find someone who can do a review.

Reply

Unmerged revisions

429. By Michael Vogt

merged lp:click, fixes conflicts, fixed tests

428. By Michael Vogt

merged lp:click/devel

427. By Michael Vogt

click/commands/chroot.py: remove check for /etc/schroot/click/fstab. the fstab is auto-generated now

426. By Michael Vogt

generate schroot fstab (more) dynamically to support $HOME != /home

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: