Merge lp://staging/~mvo/click/lp1245826-multiple-hookfiles into lp://staging/click/devel
Proposed by
Michael Vogt
| Status: | Needs review | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://staging/~mvo/click/lp1245826-multiple-hookfiles | ||||
| Merge into: | lp://staging/click/devel | ||||
| Diff against target: |
299 lines (+103/-32) 3 files modified
click/tests/gimock.py (+2/-1) click/tests/test_hooks.py (+46/-2) lib/click/hooks.vala (+55/-29) |
||||
| To merge this branch: | bzr merge lp://staging/~mvo/click/lp1245826-multiple-hookfiles | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| click hackers | Pending | ||
|
Review via email:
|
|||
Commit message
Add support for multiple click hook files.
Description of the change
Add support for multiple click hook files.
This is based on the work of lp:~mardy/click/lp1245826. Feedback on the approach appreciated, the actual code needs a refactor to get rid of the duplication of the relative_path reading code.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Unmerged revisions
- 526. By Michael Vogt
-
fix pep8 failure
- 525. By Michael Vogt
-
refactor duplicated code into get_relative_
paths_for_ hookname( ) - 524. By Michael Vogt
-
add support for relative_path in get_app_hooks
- 523. By Michael Vogt
-
fix remove and add test
- 522. By Michael Vogt
-
Add support for multiple hook files
This allows writing hook files like:
"""
Pattern: %s/${id}_${basename}
"""and manifest with:
"""
hooks": {
"app": {
"service": ["target-1","target- 2"]
}
}
"""
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:524
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://