Merge lp://staging/~muktupavels/unity-greeter/fix-lp-1374778 into lp://staging/unity-greeter

Proposed by Alberts Muktupāvels
Status: Merged
Merged at revision: 1476
Proposed branch: lp://staging/~muktupavels/unity-greeter/fix-lp-1374778
Merge into: lp://staging/unity-greeter
Diff against target: 13 lines (+3/-0)
1 file modified
src/prompt-box.vala (+3/-0)
To merge this branch: bzr merge lp://staging/~muktupavels/unity-greeter/fix-lp-1374778
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+244950@code.staging.launchpad.net

Commit message

Fix prompt-box height.

Description of the change

Fix prompt-box height.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Thanks Alberts!

I discussed this with Michael Terry (the original author of this code) on IRC. While we weren't 100% sure this was correctly fixing the problem as opposed to the symptom the fix does work.

review: Approve
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

For debugging I added button_press_event to prompt-box.vala with debug ("%s", label);. When click did not select user it printed wrong label - first or even second label above clicked label.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches