Merge lp://staging/~muktupavels/compiz/pygobject-warnings into lp://staging/compiz/0.9.13

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Dmitry Shachnev
Approved revision: 4203
Merged at revision: 4204
Proposed branch: lp://staging/~muktupavels/compiz/pygobject-warnings
Merge into: lp://staging/compiz/0.9.13
Diff against target: 525 lines (+68/-71)
4 files modified
compizconfig/ccsm/ccm/Pages.py (+35/-38)
compizconfig/ccsm/ccm/Settings.py (+15/-15)
compizconfig/ccsm/ccm/Utils.py (+1/-1)
compizconfig/ccsm/ccm/Widgets.py (+17/-17)
To merge this branch: bzr merge lp://staging/~muktupavels/compiz/pygobject-warnings
Reviewer Review Type Date Requested Status
Dmitry Shachnev Approve
Review via email: mp+362818@code.staging.launchpad.net

Commit message

Fix many PyGTKDeprecationWarning warnings.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

For future, it is better to remove whitespace when passing function arguments.
Quoting from https://www.python.org/dev/peps/pep-0008/#other-recommendations:

Yes:

def complex(real, imag=0.0):
    return magic(r=real, i=imag)

No:

def complex(real, imag = 0.0):
    return magic(r = real, i = imag)

Anyway approving because it is not related to your fixes.

review: Approve
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Updated.

4203. By Alberts Muktupāvels

Fix many PyGTKDeprecationWarning warnings.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches