Compiz

Merge lp://staging/~muktupavels/compiz/gwd-don-t-unref-wnck-screen into lp://staging/compiz/0.9.12

  1. gwd-don-t-unref-wnck-screen
  2. Merge into 0.9.12
Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Stephen M. Webb
Approved revision: 3942
Merged at revision: 3957
Proposed branch: lp://staging/~muktupavels/compiz/gwd-don-t-unref-wnck-screen
Merge into: lp://staging/compiz/0.9.12
Prerequisite: lp://staging/~muktupavels/compiz/gwd-metacity-fix-button-width-calculation
Diff against target: 28 lines (+0/-12)
1 file modified
gtk/window-decorator/gwd-settings-notified.c (+0/-12)
To merge this branch: bzr merge lp://staging/~muktupavels/compiz/gwd-don-t-unref-wnck-screen
Reviewer Review Type Date Requested Status
Stephen M. Webb Approve
Review via email: mp+255254@code.staging.launchpad.net

Commit message

gtk-window-decorator: fix crash on exit.

Description of the change

Don't unref wnck screen.

https://developer.gnome.org/libwnck/stable/WnckScreen.html#wnck-screen-get-default
The returned WnckScreen is owned by libwnck and must not be referenced or unreferenced.

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

Is there a bug associated with this fix?

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

> Is there a bug associated with this fix?

Did not search - I don't know.

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

> Is there a bug associated with this fix?

I found one bug for this bug - 1061282.

Revision history for this message
Stephen M. Webb (bregma) wrote :

Build OK. No crash on logout.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches