Midori Web Browser

Merge lp://staging/~muesli4-2/midori/panel-resizing into lp://staging/midori

  1. panel-resizing
  2. Merge into trunk
Proposed by Moritz Bruder
Status: Needs review
Proposed branch: lp://staging/~muesli4-2/midori/panel-resizing
Merge into: lp://staging/midori
Diff against target: 172 lines (+51/-6)
3 files modified
midori/midori-browser.c (+30/-6)
midori/midori-preferences.c (+3/-0)
midori/midori-websettings.c (+18/-0)
To merge this branch: bzr merge lp://staging/~muesli4-2/midori/panel-resizing
Reviewer Review Type Date Requested Status
gue5t gue5t Needs Information
Review via email: mp+280399@code.staging.launchpad.net

Description of the change

I changed the way the side panel and the *vpaned* (containing the webview) are added to and contained within the *hpaned*. In particular, I changed the "shrink" property to allow the side panel to shrink further.

I added an option within the preferences, which is disabled by default but stored within the settings once enabled! (I hope I didn't forget anything, but works flawless on my machine.)

Especially on netbooks with small screen this is absolutely necessary, when using vertical tabs.

To post a comment you must log in.
Revision history for this message
Moritz Bruder (muesli4-2) wrote :

I found out that the "last-panel-position" property, which was already in the code, is not saved for the next session.

This leads sometimes to unpredictable positions. I guess it would be best to install the property in the MidoriWebSettings class. I could do this, but I would like to hear your thoughts on the issue.

Reply
Revision history for this message
Paweł Forysiuk (tuxator) wrote :

Any particular scenario for notebook case? For example what size browser should be there?

Reply
Revision history for this message
Moritz Bruder (muesli4-2) wrote :

> Any particular scenario for notebook case? For example what size browser
> should be there?

My netbook has a resolution of 1024x600, the vertical side panel in its minimal width takes almost 1/3 of the screen. Furthermore I don't see any reason to limit it.

Reply
Revision history for this message
gue5t gue5t (gue5t) wrote :

Allowing to shrink the sidepanel for small screens seems completely reasonable.

I think the preference for whether to allow shrinking or not is probably unnecessary. Unchecking the checkbox doesn't seem to help users with small screens (who need it checked) nor users with large screens (who will simply not shrink the sidepanel so much). Or am I missing something?

The last-panel-position thing can probably be addressed in a separate branch or on top of this one.

review: Needs Information
Reply

Unmerged revisions

7072. By Moritz Bruder

Added flexible resizing support for the side panel (with an opt-in setting, default is still the same).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: