Merge lp://staging/~mthaddon/openstack-mojo-specs/mojo-nagios-check into lp://staging/openstack-mojo-specs
Proposed by
Tom Haddon
| Status: | Merged |
|---|---|
| Merged at revision: | 285 |
| Proposed branch: | lp://staging/~mthaddon/openstack-mojo-specs/mojo-nagios-check |
| Merge into: | lp://staging/openstack-mojo-specs |
| Diff against target: |
83 lines (+4/-37) 4 files modified
helper/tests/run_nagios_checks.py (+0/-33) specs/dev/full_nrpe/manifest (+1/-1) specs/dev/nova_cc_legacy_neutron/utils/mojo_utils.py (+2/-2) specs/dev/swift_nrpe/simple_nonha/manifest (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~mthaddon/openstack-mojo-specs/mojo-nagios-check |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Ames (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Switch to using Mojo's built in nagios-check phase rather than maintaining a custom script. Note that this phase will throw an ERROR if any machines with services running don't have nagios checks configured, so you'd need to confirm that'll not break things before merging.
There's also a bunch of other options to consider when running this phase per https:/
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
In the OpenStack Charms team we rarely use nagios and our goal is to move toward tempest for the validation phase.
Having said that, it does make more sense to utilize the built in feature for when we do use nagios.
Approved.