Merge into db-devel : haproxy-offline-switch-page : Code : Launchpad itself

Merge lp://staging/~mthaddon/launchpad/haproxy-offline-switch-page into lp://staging/launchpad/db-devel

Proposed by Tom Haddon
Status: Rejected
Rejected by: Tom Haddon
Proposed branch: lp://staging/~mthaddon/launchpad/haproxy-offline-switch-page
Merge into: lp://staging/launchpad/db-devel
Diff against target: 37 lines (+31/-0)
1 file modified
To merge this branch: bzr merge lp://staging/~mthaddon/launchpad/haproxy-offline-switch-page
Reviewer Review Type Date Requested Status
Tom Haddon (community) Disapprove
Michael Nelson (community) code Approve
Review via email: mp+18442@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Tom Haddon (mthaddon) wrote :

We need two pages for haproxy, just in the same way that we have two offline pages for apache that we can switch between based on whether we're in a planned outage or not.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hi Tom,

This all looks fine, except for the link provided for more information (or perhaps the redirection behind it). Currently:

http://news.launchpad.net/maintenance (which I assume will be live even when LP is down) redirects to http://blog.launchpad.net/maintenance, which states: This page has moved to: https://dev.launchpad.net/Maintenance.

So I'm guessing you'll either want to update the redirect, or update the link both here and on the normal offline-maintenance.html template?

Thanks!

review: Approve (code)
Revision history for this message
Gavin Panella (allenap) wrote :

Is this still relevant?

Revision history for this message
Tom Haddon (mthaddon) wrote :

No, this isn't relevant anymore - we already have the files we need. Will discard this one.

review: Disapprove

Unmerged revisions

8951. By Tom Haddon

Add an haproxy-compatible change for haproxy that covers planned maintenance

Preview Diff

Failed to fetch available diffs.

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'lib/canonical/launchpad/offline-maintenance-haproxy.html'
2--- lib/canonical/launchpad/offline-maintenance-haproxy.html 1970-01-01 00:00:00 +0000
3+++ lib/canonical/launchpad/offline-maintenance-haproxy.html 2010-02-02 08:30:30 +0000
4@@ -0,0 +1,31 @@
5+HTTP/1.1 503 Service Unavailable
6+Content-Type: text/html
7+
8+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
9+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
10+ <head>
11+ <title>Please try again</title>
12+ <style type="text/css" media="screen, print">
13+ .offline{text-align:center;margin:2em 0}
14+ </style>
15+ </head>
16+ <body>
17+ <div class="offline">
18+ <!-- Before editing, please see
19+ https://bugs.launchpad.net/bugs/475371, especially comment #2,
20+ for details on this file. In particular, please maintain the
21+ \r\n line endings, at least for the HTTP header lines. -->
22+ <h1>Sorry</h1>
23+ <p>
24+ Launchpad is offline for scheduled maintenance.
25+ We should be back soon.
26+ </p>
27+ <p>
28+ For more about Launchpad&rsquo;s maintenance schedule, check
29+ <a href="http://news.launchpad.net/maintenance">Launchpad News</a>.
30+ </p>
31+ <p>Thanks for your patience.</p>
32+
33+ </div>
34+ </body>
35+</html>
36
37=== renamed file 'lib/canonical/launchpad/offline-haproxy.html' => 'lib/canonical/launchpad/offline-unplanned-haproxy.html'

Subscribers

People subscribed via source and target branches

to status/vote changes: