lp://staging/~mthaddon/codetree/requests-contextlib-1884297

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/codetree at revision 121

Haw Loeung: Approve (+1) on 2020-06-23

Guillermo Gonzalez (community): Approve on 2020-06-22

Canonical IS Reviewers: Pending requested 2020-06-22

Diff: 44 lines (+8/-2)

2 files modified

codetree/handlers/charm.py (+5/-2)
tests/test_charm_handler.py (+3/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1884297: AttributeError: __exit__ when downloading charm from the store

High

Fix Committed

Link a bug report

Related blueprints

121. By Tom Haddon on 2020-06-22

Add a closing wrapper for requests.get per lp#1884297

120. By Stuart Bishop on 2020-06-15

Bump setup.py Python version number

119. By Stuart Bishop on 2020-06-15

Drop Python2 support

Reviewed-on: https://code.launchpad.net/~stub/codetree/nopy2/+merge/385491
Reviewed-by: Tom Haddon <email address hidden>

118. By Benjamin Allot on 2020-06-15

Write the file as binary blob when read from HTTP response

Reviewed-on: https://code.launchpad.net/~ballot/codetree/fix_httphandler_write/+merge/385693
Reviewed-by: Stuart Bishop <email address hidden>

117. By Tom Haddon on 2020-06-09

Make sure we correctly process config files that are empty or comments only

Reviewed-on: https://code.launchpad.net/~mthaddon/codetree/comments-only/+merge/385390
Reviewed-by: Benjamin Allot <email address hidden>
Reviewed-by: Daniel Manrique <email address hidden>
Reviewed-by: Joel Sing <email address hidden>

116. By Stuart Bishop on 2020-05-05

Update snapcraft.yaml

115. By Stuart Bishop on 2020-05-05

Bump version numbers to 1.1.1

114. By Benjamin Allot on 2020-05-05

Fix the test_get_branch to really highlight the issue

This test now fails, demonstrating that trying to run
twice the same codetree with "branch" without revno result in a
"git checkout master".
If the master does not exist, this fails (and checking out
master in such case is wrong anyway).

Reviewed-on: https://code.launchpad.net/~ballot/codetree/lp1829771/+merge/382971
Reviewed-by: Stuart Bishop <email address hidden>
Reviewed-by: Laurent Sesques <email address hidden>

113. By Stuart Bishop on 2020-04-22

Fix packaging to include Python code

Reviewed-on: https://code.launchpad.net/~stub/codetree/py3-packaging/+merge/382720
Reviewed-by: Tom Haddon <email address hidden>

112. By Stuart Bishop on 2020-04-20

Packaging updates to get builds Trusty->Focal working

Reviewed-on: https://code.launchpad.net/~stub/codetree/py3-packaging/+merge/382566
Reviewed-by: Tom Haddon <email address hidden>