codetree

Merge lp://staging/~mthaddon/codetree/git-lp into lp://staging/codetree

  1. git-lp
  2. Merge into trunk
Proposed by Tom Haddon
Status: Merged
Approved by: Tom Haddon
Approved revision: 123
Merged at revision: 122
Proposed branch: lp://staging/~mthaddon/codetree/git-lp
Merge into: lp://staging/codetree
Diff against target: 85 lines (+19/-8)
3 files modified
README.md (+6/-2)
codetree/handlers/git.py (+4/-0)
tests/test_git_handler.py (+9/-6)
To merge this branch: bzr merge lp://staging/~mthaddon/codetree/git-lp
Reviewer Review Type Date Requested Status
Haw Loeung +1 Approve
Canonical IS Reviewers Pending
Review via email: mp+397476@code.staging.launchpad.net

Commit message

Add a new git+lp scheme that's a shortening for git on Launchpad

Description of the change

Add a new git+lp scheme that's a shortening for git on Launchpad

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM.

Can we also add support for git+lp:~owner/project?

For example, https://code.launchpad.net/~hloeung/charm-nrpe/+git/nrpe-charm, we could use git+lp:~hloeung/charm-nrpe which would then map back to ~hloeung/charm-nrpe/+git/nrpe-charm.

Also git+lp:~hloeung/charm-nrpe:mybranch would map to ~hloeung/charm-nrpe/+git/nrpe-charm/+ref/mybranch.

review: Approve (+1)
Revision history for this message
Tom Haddon (mthaddon) wrote :

The following two already work:

nrpe git+lp:~hloeung/charm-nrpe
nrpe2 git+lp:~guoqiao/charm-nrpe;revno=fix_yaml_load_warning

I'll update the README to clarify.

lp://staging/~mthaddon/codetree/git-lp updated
123. By Tom Haddon

Clarify other supported git+lp shortenings

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 122

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches