lp://staging/~mterry/unity8/timeout-wizard
- Get this branch:
- bzr branch lp://staging/~mterry/unity8/timeout-wizard
Branch merges
- Daniel d'Andrada (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 76 lines (+32/-2)2 files modifiedqml/Wizard/Pages.qml (+14/-1)
tests/qmltests/Wizard/tst_Wizard.qml (+18/-1)
Related bugs
Bug #1425737: Wizard can potentially wait forever on a buggy page | High | Fix Released |
|
Related blueprints
Branch information
Recent revisions
- 1636. By Michael Terry
-
Time out wizard pages, so we don't leave user sitting there if bad code exists
- 1633. By Albert Astals Cid
-
Do not declare the hostname property twice
Approved by: Michael Terry, Andrea Cimitan - 1632. By Michael Terry
-
Wait for libqofono to finish initializing before we decide whether to skip the wizard's SIM page or not.
libqofono became asynchronous on its last upload (about a month ago), which the wizard was not prepared for. We didn't notice because our mocks continued their synchronous behavior, and in manual testing, it's easy to miss (you'd have to not have a SIM in, and then notice that you *didn't* get a screen).
I've updated our mock to be asynchronous (to get the desired signal timing behavior, I switched one of our mock classes to C++ from qml).
And I've added support for artificially extending the delays in the async flow. This lets us test those delays specifically. And obviously, I added a couple tests to do so. Fixes: #1423565
Approved by: Albert Astals Cid - 1630. By Michael Terry
-
Move the gschema file to data/ and install it via cmake, not dpkg.
Approved by: Albert Astals Cid - 1629. By Albert Astals Cid
-
Make qmluittests pass with Qt 5.4
Changes:
* Make PinchArea not be a child of Flickable, otherwise when zooming out the Flickable was stealing the events from the PinchArea
* Flush touch events in some tests. Since https://qt.gitorious. org/qt/ qtdeclarative/ commit/ 6dc8f47bb05a8ac b3cbcc697e0dc05 356a01d4cf touch events are aggregated and only sent once per frame, that breaks tests that are expecting things to happen immediately, hence the flush
* Change a verify() to check for !== invalid instead of letting verify() do the cast to boolean by itself
* Make sure the pin lock buttons are enabled before tapping into them
Approved by: Andrea Cimitan, Daniel d'Andrada - 1628. By Andrea Cimitan
-
Add maximumLineCount for subtitle label in cards Fixes: #1414870
Approved by: Albert Astals Cid
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/unity8