Unity 8

Merge lp://staging/~mterry/unity8/no-shutdown-dialog-while-suspended into lp://staging/unity8

no-shutdown-dialog-while-suspended
Merge into trunk

Proposed by Michael Terry on 2015-01-14

Status:

Merged

Approved by:

Gerry Boland on 2015-01-20

Approved revision:

1547

Merged at revision:

1562

Proposed branch:

lp://staging/~mterry/unity8/no-shutdown-dialog-while-suspended

Merge into:

lp://staging/unity8

Diff against target:

21 lines (+10/-1)

1 file modified

qml/Shell.qml (+10/-1)

To merge this branch:

bzr merge lp://staging/~mterry/unity8/no-shutdown-dialog-while-suspended

Related bugs:

Bug #1409003: receiving an sms while roaming and suspended renders the phone difficult to use on resume	Undecided	New
Bug #1410830: Shutdown dialog appears on resume, after a long delay in screen turning on	Undecided	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Gerry Boland (community)		2015-01-14	Approve on 2015-01-20
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2015-01-15
Review via email: mp+246445@code.staging.launchpad.net

Commit message

Don't show any power dialogs while the screen is off. This is a band-aid to avoid the symptom, while we still investigate the source of why the screen doesn't turn on (and why we seem to not handle the power-button-release event).

Description of the change

Don't show any power dialogs while the screen is off.

From the code:

// FIXME: We only consider power key presses if the screen is
// on because of bug 1410830. The theory is that when that bug
// is encountered, there is a >2s delay between the power press
// event and the power release event, which causes the shutdown
// dialog to appear on resume. So to avoid that symptom while
// we investigate the root cause, we simply won't initiate any
// dialogs when the screen is off.

So to be clear, this is a band-aid to avoid the symptom, while we still investigate the source of why the screen doesn't turn on (and why we seem to not handle the power-button-release event).

To make it worse, this bug is hard to reproduce. I'm not even really sure this band-aid fixes the symptom. But it seems like it would. So that's basically the same, right!?

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-14:

FAILED: Continuous integration, rev:1546
http://jenkins.qa.ubuntu.com/job/unity8-ci/5147/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/804
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/311
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/312
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/312
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/700
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/802
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/802/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17078

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5147/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

kevin gunn (kgunn72) wrote on 2015-01-14:

this was tested by rick against jibel's repro method many times - this fix corrected that
since rick has the magic handset & user mojo he is currently testing his roaming-test, so far so good, testing overnight as well.

Revision history for this message

Michael Terry (mterry) wrote on 2015-01-15:

<kgunn> mterry: so rick said he never saw the poweroff dialog, but did experience the busy/slow resume

So that seems promising.

lp://staging/~mterry/unity8/no-shutdown-dialog-while-suspended updated on 2015-01-15