Unity 8

Merge lp://staging/~mterry/unity8/early-disable into lp://staging/unity8

early-disable
Merge into trunk

Proposed by Michael Terry on 2014-11-21

Status:

Merged

Approved by:

Albert Astals Cid on 2014-11-24

Approved revision:

1451

Merged at revision:

1466

Proposed branch:

lp://staging/~mterry/unity8/early-disable

Merge into:

lp://staging/unity8

Diff against target:

59 lines (+8/-1)

4 files modified

qml/Shell.qml (+5/-1)
tests/qmltests/tst_Shell.qml (+1/-0)
tests/qmltests/tst_ShellWithPin.qml (+1/-0)
tests/qmltests/tst_TabletShell.qml (+1/-0)

To merge this branch:

bzr merge lp://staging/~mterry/unity8/early-disable

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Albert Astals Cid (community)		2014-11-21	Approve on 2014-11-24
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2014-11-24
Review via email: mp+242517@code.staging.launchpad.net

Commit message

Make sure that there is no window of opportunity for swiping away greeter before the lockscreen appears.

We actually have code to do this already, but it only protected starting from the greeter's onShowChanged call. So this branch starts the shell disabled from the get-go.

Description of the change

Make sure that there is no window of opportunity for swiping away greeter before the lockscreen appears.

We actually have code to do this already, but it only protected starting from the greeter's onShowChanged call. So this branch starts the shell disabled from the get-go.

== Checklist ==

* Are there any related MPs required for this MP to build/function as expected? Please list.
No

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

* Did you make sure that your branch does not contain spurious tags?
Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
NA

* If you changed the UI, has there been a design review?
NA

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-21:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4952/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Albert Astals Cid (aacid) wrote on 2014-11-24:

Lots of failed qmluitests, please have a look.

review: Needs Fixing

Revision history for this message

Albert Astals Cid (aacid) wrote on 2014-11-24:

qmluitests that seem to have to do with this

qmltestrunner.TabletShell::test_appLaunchDuringGreeter
qmltestrunner.TabletShell::test_leftEdgeDrag
qmltestrunner.TabletShell::test_login
qmltestrunner.TabletShell::test_noLockscreen
qmltestrunner.TabletShell::test_showAndHideGreeterDBusCalls