Merge lp://staging/~mterry/unity8-desktop-session/copy-env into lp://staging/unity8-desktop-session

Proposed by Michael Terry
Status: Merged
Approved by: Ken VanDine
Approved revision: 126
Merged at revision: 126
Proposed branch: lp://staging/~mterry/unity8-desktop-session/copy-env
Merge into: lp://staging/unity8-desktop-session
Diff against target: 67 lines (+37/-0)
3 files modified
data/Makefile.am (+4/-0)
data/unity8-copy-env.conf (+32/-0)
debian/unity8-desktop-session.install (+1/-0)
To merge this branch: bzr merge lp://staging/~mterry/unity8-desktop-session/copy-env
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Review via email: mp+320848@code.staging.launchpad.net

Commit message

Copy our upstart environment into dbus and systemd, making sure that activated services have the correct environment.

Description of the change

As noted in the comments for the upstart job, this is a temporary solution. We are actively working on dropping upstart altogether. But I didn't want to block bug 1675437 and silos that are moving bits to systemd on us getting the last piece in place.

So this just manually does the copying for now, after unity8 starts. We'll need to revamp this when we drop upstart obviously.

(Testing note: the systemd portion of this does not work in xenial -- or at least xenial+overlay. The dbus API for xenial's systemd doesn't work.)

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

I think this is a reasonable solution for now. I've tested this on a clean zesty install, works great.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches