Merge lp://staging/~mterry/unity-lens-music/valac-0.18 into lp://staging/unity-lens-music
Proposed by
Michael Terry
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michal Hruby | ||||
| Approved revision: | 122 | ||||
| Merged at revision: | 124 | ||||
| Proposed branch: | lp://staging/~mterry/unity-lens-music/valac-0.18 | ||||
| Merge into: | lp://staging/unity-lens-music | ||||
| Prerequisite: | lp://staging/~mterry/unity-lens-music/gst1 | ||||
| Diff against target: |
242 lines (+48/-48) 9 files modified
configure.ac (+1/-1) debian/control (+1/-1) debian/rules (+5/-0) src/Makefile.am (+3/-1) src/banshee-scope.vala (+4/-11) src/musicstore-collection.vala (+2/-2) src/player.vala (+3/-3) src/rhythmbox-collection.vala (+2/-2) src/rhythmbox-scope.vala (+27/-27) |
||||
| To merge this branch: | bzr merge lp://staging/~mterry/unity-lens-music/valac-0.18 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Pending | |
|
Review via email:
|
|||
This proposal supersedes a proposal from 2012-12-06.
Description of the change
This fixes all the code and deprecation warnings we see with valac-0.18. It also makes sure to prefer valac-0.18 if there are more than one valac executables installed.
I also bumped the minimum glib to 2.32 for the new, non-deprecated glib thread API.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Awesome, thanks for the fixes!