Merge lp://staging/~mterry/ubuntuone-couch/queries into lp://staging/ubuntuone-couch

Proposed by Michael Terry
Status: Merged
Approved by: dobey
Approved revision: 10
Merged at revision: 10
Proposed branch: lp://staging/~mterry/ubuntuone-couch/queries
Merge into: lp://staging/ubuntuone-couch
Diff against target: 26 lines (+7/-1)
1 file modified
ubuntuone/couch/auth.py (+7/-1)
To merge this branch: bzr merge lp://staging/~mterry/ubuntuone-couch/queries
Reviewer Review Type Date Requested Status
Eric Casteleijn (community) Approve
dobey (community) Approve
Review via email: mp+61658@code.staging.launchpad.net

Commit message

Handle query parameters in auth.request()

To post a comment you must log in.
9. By Michael Terry

merge from trunk

Revision history for this message
Eric Casteleijn (thisfred) wrote :

Sorry for only getting to this now, I must have overlooked the merge proposal mail. This looks great, only one very minor nitpick: ubuntuone-couch uses pylint (and pep8) to check for some common problems/style issues, and thus we've bought in to most of its (admittedly arbitrary) standards.

In this case it complains about single character variable names:

ubuntuone/couch/auth.py:
    113: [C0103, request] Invalid name "v" (should match [a-z_][a-z0-9_]{1,30}$)

So if you could make k and v into (for instance) key and value, to shut pylint up, that would be awesome.

Running ./run-tests in your branch will show you these issues locally, provided you have the needed dependencies installed. Installing ubuntuone-dev-tools will give you all of them.

10. By Michael Terry

give longer variable names to avoid test warning

Revision history for this message
Michael Terry (mterry) wrote :

OK, updated. Note that I also had to separately install "pep8" and "python-mocker" which maybe should be added to that meta package?

Revision history for this message
dobey (dobey) wrote :

That isn't a metapackage. And ubuntuone-dev-tools does not depend on mocker or pep8 itself, to be used. However, we do need to get ubuntuone-couch set up in nightlies, and then the Build-Depends on it will pull in everything you need, so long as that PPA is enabled. Though we should probably also add those Build-Depends to the regular Ubuntu package, and have it run the tests at build time as well, if it isn't already.

Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Eric Casteleijn (thisfred) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches