Merge lp://staging/~mterry/ubuntuone-couch/queries into lp://staging/ubuntuone-couch
Proposed by
Michael Terry
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | dobey | ||||
Approved revision: | 10 | ||||
Merged at revision: | 10 | ||||
Proposed branch: | lp://staging/~mterry/ubuntuone-couch/queries | ||||
Merge into: | lp://staging/ubuntuone-couch | ||||
Diff against target: |
26 lines (+7/-1) 1 file modified
ubuntuone/couch/auth.py (+7/-1) |
||||
To merge this branch: | bzr merge lp://staging/~mterry/ubuntuone-couch/queries | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Eric Casteleijn (community) | Approve | ||
dobey (community) | Approve | ||
Review via email:
|
Commit message
Handle query parameters in auth.request()
To post a comment you must log in.
Sorry for only getting to this now, I must have overlooked the merge proposal mail. This looks great, only one very minor nitpick: ubuntuone-couch uses pylint (and pep8) to check for some common problems/style issues, and thus we've bought in to most of its (admittedly arbitrary) standards.
In this case it complains about single character variable names:
ubuntuone/ couch/auth. py: a-z0-9_ ]{1,30} $)
113: [C0103, request] Invalid name "v" (should match [a-z_][
So if you could make k and v into (for instance) key and value, to shut pylint up, that would be awesome.
Running ./run-tests in your branch will show you these issues locally, provided you have the needed dependencies installed. Installing ubuntuone-dev-tools will give you all of them.