Merge lp://staging/~mterry/ubuntu-system-settings/less-ubuntucolors into lp://staging/ubuntu-system-settings
Proposed by
Michael Terry
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Ken VanDine | ||||
| Approved revision: | 1657 | ||||
| Merged at revision: | 1663 | ||||
| Proposed branch: | lp://staging/~mterry/ubuntu-system-settings/less-ubuntucolors | ||||
| Merge into: | lp://staging/ubuntu-system-settings | ||||
| Diff against target: |
209 lines (+13/-23) 9 files modified
plugins/background/Components/AddRemove.qml (+0/-2) plugins/background/Components/HighlightedOverlay.qml (+1/-1) plugins/cellular/Components/LabelTextField.qml (+1/-1) plugins/cellular/PageChooseApn.qml (+1/-1) plugins/phone/CallForwardItem.qml (+2/-6) plugins/phone/CallForwarding.qml (+1/-1) plugins/security-privacy/LockSecurity.qml (+1/-2) plugins/security-privacy/SimPin.qml (+3/-5) plugins/system-update/PageComponent.qml (+3/-4) |
||||
| To merge this branch: | bzr merge lp://staging/~mterry/ubuntu-system-settings/less-ubuntucolors | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ken VanDine | Approve | ||
| PS Jenkins bot | continuous-integration | Pending | |
|
Review via email:
|
|||
Commit message
Update some button colors to the new theme style
Description of the change
Remove some uses of hardcoded colors, especially ones that are wrong (mostly cases of orange -> green).
But I've also removed some odd (seemingly unnecessary) specified versions of grey when all we want is the default button color.
I haven't removed all uses of UbuntuColors, just the most noticeable ones. Several uses of the various greys exist, etc. But those are less noticeably wrong than orange.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks great, thanks!