Light Display Manager

Merge lp://staging/~mterry/lightdm/upstart into lp://staging/lightdm

  1. upstart
  2. Merge into trunk
Proposed by Michael Terry
Status: Merged
Merged at revision: 1084
Proposed branch: lp://staging/~mterry/lightdm/upstart
Merge into: lp://staging/lightdm
Diff against target: 63 lines (+23/-0)
2 files modified
data/init/lightdm.conf (+3/-0)
src/seat.c (+20/-0)
To merge this branch: bzr merge lp://staging/~mterry/lightdm/upstart
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+73082@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Feedback:
- It emits 'user-session-start' instead of 'desktop-session-start' as listed in lightdm.conf and the .pdf.
- It's probably easier to do this in seat.c and do this in the ready and session-started signal handlers.

I'm not sure what the exact point of the events are (will ask more in the bug).

review: Needs Fixing
lp://staging/~mterry/lightdm/upstart updated
1070. By Michael Terry

move upstart signal emission to seat.c

Revision history for this message
Michael Terry (mterry) wrote :

Good catch on user-session-start.

I've updated this branch to fix that and move the code to seat.c. Please re-review.

lp://staging/~mterry/lightdm/upstart updated
1071. By Michael Terry

merge from trunk

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Not sure if they are in the right place, but I'll apply this for now and we can move them if they're not right.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches