Merge lp://staging/~mterry/libindicator/rename-unit into lp://staging/libindicator

Proposed by Michael Terry
Status: Needs review
Proposed branch: lp://staging/~mterry/libindicator/rename-unit
Merge into: lp://staging/libindicator
Diff against target: 42 lines (+14/-1)
4 files modified
data/Makefile.am (+1/-1)
data/indicators.target (+5/-0)
debian/changelog (+6/-0)
debian/indicator-common.links (+2/-0)
To merge this branch: bzr merge lp://staging/~mterry/libindicator/rename-unit
Reviewer Review Type Date Requested Status
Ted Gould Pending
Indicator Applet Developers Pending
Review via email: mp+321556@code.staging.launchpad.net

Commit message

Use indicators.target as the systemd lifecycle unit, not indicators-pre.target.

Description of the change

This MP might just be my inexperience with systemd conventions, but I think "indicators.target" makes more sense than "indicators-pre.target"?

With this MP, indicators can do the following:

[Unit]
PartOf=indicators.target
[Install]
WantedBy=indicators.target

And then they will start, restart, and stop when indicators.target is. And unity8 can simply say Wants=indicators.target when it starts up (or manually start it, whatever).

Indicators don't seem to be started by anything now, but I plan to add the above stanza to indicators if this branch is liked.

Is indicators-pre.target separately valuable? The "-pre" stuff seems used elsewhere (like in graphical-session), but I'm not sure why we want it for indicators.

To post a comment you must log in.
538. By Michael Terry

Make indicators.target part of graphical session

Unmerged revisions

538. By Michael Terry

Make indicators.target part of graphical session

537. By Michael Terry

Bump version

536. By Michael Terry

Rename indicators-pre.target to indicators.target

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches