Merge lp://staging/~mterry/libappindicator/unregister-later into lp://staging/libappindicator
Proposed by
Michael Terry
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 192 | ||||
| Proposed branch: | lp://staging/~mterry/libappindicator/unregister-later | ||||
| Merge into: | lp://staging/libappindicator | ||||
| Diff against target: |
27 lines (+5/-5) 1 file modified
src/app-indicator.c (+5/-5) |
||||
| To merge this branch: | bzr merge lp://staging/~mterry/libappindicator/unregister-later | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ted Gould (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Currently, libappindicator unregisters its dbus object name first thing during dispose. But actually, it needs that name to sucessfully make some of the other calls during dispose, notably app_indicator_
So I've moved it down until right before the bus connection itself is torn down. This fixes bug 711749, which had the keyboard indicator staying around after it the appindicator object itself was disposed (because it was never set as passive).
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
review approve