Merge lp://staging/~mterry/libappindicator/let-them-eat-strings into lp://staging/libappindicator

Proposed by Michael Terry
Status: Merged
Merged at revision: 177
Proposed branch: lp://staging/~mterry/libappindicator/let-them-eat-strings
Merge into: lp://staging/libappindicator
Diff against target: 61 lines (+10/-10)
2 files modified
src/Makefile.am (+2/-2)
src/app-indicator.c (+8/-8)
To merge this branch: bzr merge lp://staging/~mterry/libappindicator/let-them-eat-strings
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Review via email: mp+46212@code.staging.launchpad.net

Description of the change

Don't try to construct GVariants with nulls. It causes a lot of error spew as well as crashes when these properties are poked in d-feet. I only did this for the optional properties.

To post a comment you must log in.
178. By Michael Terry

aw shucks, do the required properties too, defensively

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches