indicator-power

Merge lp://staging/~mterry/indicator-power/add-greeter-mode into lp://staging/~jjardon/indicator-power/master

  1. add-greeter-mode
  2. Merge into master
Proposed by Michael Terry
Status: Merged
Merged at revision: 88
Proposed branch: lp://staging/~mterry/indicator-power/add-greeter-mode
Merge into: lp://staging/~jjardon/indicator-power/master
Diff against target: 67 lines (+30/-20)
1 file modified
src/indicator-power.c (+30/-20)
To merge this branch: bzr merge lp://staging/~mterry/indicator-power/add-greeter-mode
Reviewer Review Type Date Requested Status
Javier Jardón Approve
Review via email: mp+70345@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Javier Jardón (jjardon) wrote :

Why do you want to hide the "Show time in Menu Bar" option in the Greeter mode?

review: Needs Information
Revision history for this message
Michael Terry (mterry) wrote :

A) It's a configuration option that seems odd to have on the main screen. For example, user A comes by and toggles it, but then user B comes by and doesn't like it so toggles it back.

B) Mika's unity-greeter design didn't have it.

Revision history for this message
Javier Jardón (jjardon) wrote :

Ok, thanks for the info. Merged

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: