The Me Menu

Merge lp://staging/~mterry/indicator-me/gsettings into lp://staging/indicator-me

gsettings
Merge into trunk

Proposed by Michael Terry on 2010-10-08

Status:	Superseded
Proposed branch:	lp://staging/~mterry/indicator-me/gsettings
Merge into:	lp://staging/indicator-me
Diff against target:	189 lines (+40/-36) 6 files modified configure.ac (+4/-2) data/Makefile.am (+11/-2) data/indicator-me.convert (+2/-0) data/org.ayatana.indicator.me.gschema.xml.in (+10/-0) po/POTFILES.in (+1/-0) src/me-service.c (+12/-32)
To merge this branch:	bzr merge lp://staging/~mterry/indicator-me/gsettings
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Ted Gould (community)		2010-10-08	Needs Fixing on 2011-02-07
Review via email: mp+38005@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2011-04-18.

Description of the change

One big concern I had with this conversion was that indicator-datetime is apparently using /apps/indicators/XXX for their gsettings paths. But indicator-me was using /system/indicator/XXX in gconf.

I conservatively kept using /system/indicator/XXX, but if the Brand New Thing is /apps/indicators, just modify data/org.ayatana.indicator.me.gschema.xml.in to match (the path attribute near the top).

lp://staging/~mterry/indicator-me/gsettings updated on 2010-10-08

114. By Michael Terry on 2010-10-08: use gsettings, not gconf

Revision history for this message

Ted Gould (ted) wrote on 2010-10-08:

On Fri, 2010-10-08 at 19:01 +0000, Michael Terry wrote:
> One big concern I had with this conversion was that indicator-datetime is
> apparently using /apps/indicators/XXX for their gsettings paths. But
> indicator-me was using /system/indicator/XXX in gconf.

I like /apps because it seems like that's where people are putting
things that aren't part of GNOME Core. But, we should probably get a
definitive answer here.

Also, it seems to me this key should be an enum in gsettings (as it
supports that) instead of an int. Thoughts?

Revision history for this message

Michael Terry (mterry) wrote on 2010-10-08:

I agree that this key would be an enum if we designed it from scratch. However, the gsettings documentation leads me to believe that enums are stored as strings. And gsettings-data-convert does not handle any sort of data transformation.

So you'd have to use some new key like 'display_enum', keep 'display' around, and then convert values yourself after both are in dconf. Doesn't seem worth it.

Revision history for this message

Ted Gould (ted) wrote on 2010-10-12:

On Fri, 2010-10-08 at 23:52 +0000, Michael Terry wrote:
> I agree that this key would be an enum if we designed it from scratch. However, the gsettings documentation leads me to believe that enums are stored as strings. And gsettings-data-convert does not handle any sort of data transformation.
>
> So you'd have to use some new key like 'display_enum', keep 'display' around, and then convert values yourself after both are in dconf. Doesn't seem worth it.

Ah, sucks. Probably worth sticking with the int then. No cool new
feature use :)

lp://staging/~mterry/indicator-me/gsettings updated on 2010-10-12