Merge lp://staging/~mterry/deja-dup/midnight-epoch into lp://staging/deja-dup/26
Proposed by
Michael Terry
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 1441 | ||||
| Proposed branch: | lp://staging/~mterry/deja-dup/midnight-epoch | ||||
| Merge into: | lp://staging/deja-dup/26 | ||||
| Diff against target: |
70 lines (+47/-0) 1 file modified
common/CommonUtils.vala (+47/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~mterry/deja-dup/midnight-epoch | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robert Bruce Park (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Spread the backup time love around. We were accidentally starting our "backup day" at midnight UTC, instead of midnight local time.
While fixing this, I added some randomization to spread the load around a little bit more and set the random range from 2-4AM.
I welcome suggestions on adding tests for this. I ended up just adding print statements to make everything was as expected. I miss having Python's mock module available to me at times like these.
If we're unsure of how to test, I guess manual print testing will have to suffice.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Nice diff, builds cleanly, looks like it even works, too ;-)