Merge lp://staging/~mskalka/juju-ci-tools/update-nh-charm into lp://staging/juju-ci-tools/repository
Proposed by
Michael Skalka
| Status: | Merged |
|---|---|
| Merged at revision: | 85 |
| Proposed branch: | lp://staging/~mskalka/juju-ci-tools/update-nh-charm |
| Merge into: | lp://staging/juju-ci-tools/repository |
| Diff against target: |
148 lines (+66/-31) 5 files modified
charms/network-health/actions/unit-info.py (+1/-29) charms/network-health/files/token.txt (+1/-0) charms/network-health/metadata.yaml (+1/-1) charms/network-health/reactive/network-health.py (+25/-1) charms/network-health/scripts/simple-server.py (+38/-0) |
| To merge this branch: | bzr merge lp://staging/~mskalka/juju-ci-tools/update-nh-charm |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Christopher Lee (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Adds a simple HTTP server to the NH charm and spins it off as a fire and forget process during charm install.
The intention is for other charms to be able to curl the NH charm address on port 80 and return the contents of token.txt for a better network test than ping. This is done as a bit of a hack, and I'm not entirely happy with it, but it functions for now. Suggestions for improvement highly welcome.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM