Merge lp://staging/~mskalka/juju-ci-tools/assess_add_credentials into lp://staging/juju-ci-tools

Proposed by Michael Skalka
Status: Merged
Merged at revision: 2002
Proposed branch: lp://staging/~mskalka/juju-ci-tools/assess_add_credentials
Merge into: lp://staging/juju-ci-tools
Diff against target: 626 lines (+617/-0)
2 files modified
assess_add_credentials.py (+307/-0)
tests/test_assess_add_credentials.py (+310/-0)
To merge this branch: bzr merge lp://staging/~mskalka/juju-ci-tools/assess_add_credentials
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+322596@code.staging.launchpad.net

Description of the change

Adds assess_add_credentials.

This test pulls in credential information from cloud-city then manually adds those credentials to a new temporary JUJU_HOME, verifies they were written properly, and attempts to bootstrap using those those credentials from the temp directory.

The test will fail if the credentials inputted do not match the supplied credentials, or if the client cannot bootstrap with the credentials.

Currently this test will always fail on GCE as reported by bug #1682562.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you. I have some suggestions inline to make the script run on all hosts.

review: Approve (code)
2000. By Michael Skalka

changes as per MP comments

Revision history for this message
Michael Skalka (mskalka) wrote :

Made the suggested changes.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches