Merge ~mskalka/cloud-init:zfs-package-fix into cloud-init:master

Proposed by Michael Skalka
Status: Rejected
Rejected by: Chad Smith
Proposed branch: ~mskalka/cloud-init:zfs-package-fix
Merge into: cloud-init:master
Diff against target: 13 lines (+1/-1)
1 file modified
cloudinit/config/cc_lxd.py (+1/-1)
Reviewer Review Type Date Requested Status
cloud-init Commiters Pending
Review via email: mp+357775@code.staging.launchpad.net

Commit message

Fix the ZFS package name in the LXD module to point to a real package.

On 16.04 and earlier, 'apt-get install zfs' would select the
zfsutils-linux package correctly. After that (currently 18.04+)
it will just error.

The change here will still work on 16.04 as the zfsutils-linux
package is available there.

LP: #1799779

To post a comment you must log in.
Revision history for this message
Scott Moser (smoser) wrote :

Pointed jenkins c-i at this
 https://jenkins.ubuntu.com/server/job/cloud-init-ci/413/console
it should report shortly.

Revision history for this message
Scott Moser (smoser) wrote :

looks like you will have to fix a test. so please do that, and then i'll approve.

Revision history for this message
Chad Smith (chad.smith) wrote :

Thanks for this contribution Michael, another contributor added the unit tests requested to your branch and this was landed by cloud-init landers.

https://code.launchpad.net/~johnsonshi/cloud-init/+git/cloud-init/+merge/361854

Revision history for this message
Chad Smith (chad.smith) wrote :

Marking rejected as it got resubmitted and landed. Thanks again for noticing and fixing this

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches