Merge lp://staging/~msabramo/testrepository/add_logging into lp://staging/~testrepository/testrepository/trunk

Proposed by Marc Abramowitz
Status: Needs review
Proposed branch: lp://staging/~msabramo/testrepository/add_logging
Merge into: lp://staging/~testrepository/testrepository/trunk
Diff against target: 64 lines (+12/-0)
1 file modified
testrepository/setuptools_command.py (+12/-0)
To merge this branch: bzr merge lp://staging/~msabramo/testrepository/add_logging
Reviewer Review Type Date Requested Status
Robert Collins Needs Fixing
Review via email: mp+216532@code.staging.launchpad.net

Description of the change

testrepository/setuptools_command.py: Add logging

to aid in debugging and testing.

I submitted the same change to pbr as https://review.openstack.org/89203

The interesting thing is that with this change in both pbr and testrepository I can see that there is weird behavior when one runs `python setup.py testr` -- methods for distutils commands defined in both are called.

```
 ❯ .tox/cover/bin/python setup.py testr --coverage
INFO:pbr.testr_command:imported
INFO:pbr.testr_command:initialize_options called
INFO:testrepository.setuptools_command:imported
running testr
INFO:testrepository.setuptools_command:initialize_options called
INFO:testrepository.setuptools_command:finalize_options called
INFO:testrepository.setuptools_command:run called
INFO:testrepository.setuptools_command:_coverage_before called
INFO:testrepository.setuptools_command:os.environ['PYTHON'] = 'coverage run --source jenkins-job-builder --parallel-mode'
INFO:testrepository.setuptools_command:_run_testr called
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} OS_LOG_CAPTURE=${OS_LOG_CAPTURE:-1}
```

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

Hi! Could you repropose this to master - https://github.com/testing-cabal/testrepository? Thanks!

Revision history for this message
Robert Collins (lifeless) :
review: Needs Fixing
Revision history for this message
Marc Abramowitz (msabramo) wrote :

Unmerged revisions

241. By Marc Abramowitz <email address hidden>

testrepository/setuptools_command.py: Add logging

to aid in debugging and testing.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches