Ubuntu Document Viewer App

Merge lp://staging/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-lib-cache into lp://staging/ubuntu-docviewer-app

  1. ubuntu-docviewer-app-lib-cache
  2. Merge into lo-viewer
Proposed by Roman Shchekin
Status: Merged
Approved by: Stefano Verzegnassi
Approved revision: 261
Merged at revision: 266
Proposed branch: lp://staging/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-lib-cache
Merge into: lp://staging/ubuntu-docviewer-app
Diff against target: 33 lines (+18/-5)
1 file modified
cmake/modules/Click.cmake (+18/-5)
To merge this branch: bzr merge lp://staging/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-lib-cache
Reviewer Review Type Date Requested Status
Stefano Verzegnassi Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+282652@code.staging.launchpad.net

Commit message

Upstream libs caching.

Description of the change

Upstream libs caching.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:261
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/110/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/384/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/110/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Roman Shchekin (mrqtros) wrote :

Something is wrong with tests...

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:261
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/116/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/390/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/116/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:261
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/130/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/405/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/130/rebuild

review: Approve (continuous-integration)
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

It works great, I must approve it! \o/

I have just some doubt about the multi-arch support, since the latest release of 'Ubuntu SDK' has the new "CMake Wizard" which, by default, could assign the same name[1] to the build folder, even if two different kits (e.g. "desktop" and "UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid") are used[2].
Anyway, that's IMHO just a small payback we only need to keep in mind.

[1] <source_folder> + "-build" suffix
[2] Older version always used to append the kit name as suffix

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches