Merge lp://staging/~mpt/ubuntu-ui-toolkit/1542099-window-title into lp://staging/ubuntu-ui-toolkit
Proposed by
Matthew Paul Thomas
| Status: | Rejected |
|---|---|
| Rejected by: | Zsombor Egri |
| Proposed branch: | lp://staging/~mpt/ubuntu-ui-toolkit/1542099-window-title |
| Merge into: | lp://staging/ubuntu-ui-toolkit |
| Diff against target: |
21 lines (+0/-11) 1 file modified
src/Ubuntu/Components/1.3/MainView.qml (+0/-11) |
| To merge this branch: | bzr merge lp://staging/~mpt/ubuntu-ui-toolkit/1542099-window-title |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zsombor Egri | Disapprove | ||
| PS Jenkins bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Description of the change
Warning: I have not tested this change at all.
It removes code that appears to set the window title to be the same as the header title.
Setting the window title to be the same as the header title is undesirable for two reasons: it’s highly visible redundancy, and whenever the app has multiple screens it means the window title often isn’t the name of the app.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Unmerged revisions
- 1281. By Matthew Paul Thomas
-
Stops changing an app's window title when the header changes.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:1281
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://