uvtool

Merge lp://staging/~mpontillo/uvtool/fix-unit-tests-libvirt-register-error-handler into lp://staging/~uvtool-dev/uvtool/trunk

  1. fix-unit-tests-libvirt-register-error-handler
  2. Merge into trunk
Proposed by Mike Pontillo
Status: Merged
Merge reported by: Robie Basak
Merged at revision: not available
Proposed branch: lp://staging/~mpontillo/uvtool/fix-unit-tests-libvirt-register-error-handler
Merge into: lp://staging/~uvtool-dev/uvtool/trunk
Diff against target: 15 lines (+4/-1)
1 file modified
uvtool/tests/test_simplestreams.py (+4/-1)
To merge this branch: bzr merge lp://staging/~mpontillo/uvtool/fix-unit-tests-libvirt-register-error-handler
Reviewer Review Type Date Requested Status
uvtool development Pending
Review via email: mp+297237@code.staging.launchpad.net

Commit message

Fix unit tests to include libvirt.registerErrorHandler() call.

Description of the change

It looks like unit tests were broken as part of the fix for bug #1228231.

In order to get the unit tests passing (as specified in debian/rules) I had to make this change.

To post a comment you must log in.
Revision history for this message
Robie Basak (racb) wrote :

Fixed in git master, thanks. Rather than adding the registerErrorHandler call, I just put the existing call in a list, which makes assert_has_calls work correctly. I was intending to test that "open" was called at least once, rather than the entire set.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches