Merge lp://staging/~mpontillo/maas/dns-dhcp-fixes--bug-1686234 into lp://staging/~maas-committers/maas/trunk
Proposed by
Mike Pontillo
Status: | Merged |
---|---|
Approved by: | Mike Pontillo |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6038 |
Proposed branch: | lp://staging/~mpontillo/maas/dns-dhcp-fixes--bug-1686234 |
Merge into: | lp://staging/~maas-committers/maas/trunk |
Diff against target: | 766 lines (+419/-69) |
To merge this branch: | bzr merge lp://staging/~mpontillo/maas/dns-dhcp-fixes--bug-1686234 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Blake Rouse (community) | Approve | ||
Andres Rodriguez (community) | Needs Information | ||
Review via email: mp+323198@code.staging.launchpad.net |
Commit message
Fix automatic addition and removal of hostnames provided by DHCP.
* Hostnames belonging to a Node can no longer be eclipsed by a dynamic hostname.
* DNS resources already containing a static IP address can no longer be modified by DHCP lease events.
* DNS resources are now properly removed when the last dynamic IP address associated with them is deleted.
* Logging has been added when adding or removing a dynamic hostname.
* Dynamic IP addresses are no longer deleted and recreated when not necessary.
* Move the coerce_
To post a comment you must log in.
overall it looks good, I just have a few questions inline.