MAAS

Merge ~mpontillo/maas:ignore-tunnel-interfaces--bug-1788780 into maas:master

Proposed by Mike Pontillo on 2018-08-24

Status:

Merged

Approved by:

Mike Pontillo on 2018-08-24

Approved revision:

87b44b8a9f1b9ed5fa319dfdb95fcb22824d8bfb

Merge reported by:

MAAS Lander

Merged at revision:

not available

Proposed branch:

~mpontillo/maas:ignore-tunnel-interfaces--bug-1788780

Merge into:

maas:master

Diff against target:

98 lines (+37/-2)

4 files modified

src/provisioningserver/utils/ipaddr.py (+2/-0)
src/provisioningserver/utils/network.py (+13/-1)
src/provisioningserver/utils/tests/test_ipaddr.py (+12/-1)
src/provisioningserver/utils/tests/test_network.py (+10/-0)

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Andres Rodriguez (community)			Needs Information on 2018-08-24
Newell Jensen (community)		2018-08-24	Approve on 2018-08-24
MAAS Lander	unittests		Pending
Review via email: mp+353736@code.staging.launchpad.net

Commit message

LP: #1788780 - Ignore tunnel interfaces (such as those created by hypervisors) when gathering interfaces for MAAS management.

Revision history for this message

Newell Jensen (newell-jensen) wrote on 2018-08-24:

review: Approve

Revision history for this message

Andres Rodriguez (andreserl) wrote on 2018-08-24:

what interfaces are we talking about here ?

review: Needs Information

Revision history for this message

Mike Pontillo (mpontillo) wrote on 2018-08-25:

@Andres, this is just filtering out virtual interfaces that aren't being used for anything on the host. For example, when you create a virtual machine, a virtual NIC is created on the host /and/ on the guest. The one on the host isn't being used by the host itself; it's only being used for connectivity to the virtual bridge (or other parent interface).

I don't expect this to impact any interfaces being used for MAAS operation. There is a small risk that someone crazy enough to be running MAAS on top of a TAP device to manage a remove VLAN will be impacted by this change, but I don't think we support that.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.