MAAS

Merge ~mpontillo/maas:interface-up-down-visited-recursion-prevent into maas:master

  1. Git
  2. lp:~mpontillo/maas
  3. interface-up-down-visited-recursion-prevent
  4. Merge into master
Proposed by Mike Pontillo
Status: Merged
Approved by: Mike Pontillo
Approved revision: 9d96188e8b23423ab5514dd7d741b77729a2955a
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~mpontillo/maas:interface-up-down-visited-recursion-prevent
Merge into: maas:master
Diff against target: 116 lines (+47/-14)
2 files modified
src/maasserver/models/signals/interfaces.py (+26/-12)
src/maasserver/models/signals/tests/test_interfaces.py (+21/-2)
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
MAAS Lander Approve
MAAS Maintainers Pending
Review via email: mp+348653@code.staging.launchpad.net

Commit message

LP: #1622105 - Make sure ensure_link_up does not cause infinite recursion.

Add visited pattern to interface_enabled_or_disabled post-save signal handler for Interface model objects, to fix an infinite recursion bug seen during end-to-end testing while interfaces were being enabled and disabled on a rack controller.

Description of the change

Ported forward from a branch that existed prior to the git transition:

https://code.launchpad.net/~mpontillo/maas/interface-up-down-visited-recursion-prevent/+merge/305403

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b interface-up-down-visited-recursion-prevent lp:~mpontillo/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 697b17cd08825ccbe8af33691a2c04bddc61ee58

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b interface-up-down-visited-recursion-prevent lp:~mpontillo/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 9d96188e8b23423ab5514dd7d741b77729a2955a

review: Approve
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good.

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

LANDING
-b interface-up-down-visited-recursion-prevent lp:~mpontillo/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/3313/consoleText

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches