One Hundred Scopes

Merge lp://staging/~motoster/onehundredscopes/grooveshark-precise-simple_preview into lp://staging/~davidc3/onehundredscopes/grooveshark-precise

  1. grooveshark-precise-simple_preview
  2. Merge into grooveshark-precise
Proposed by Welton Rodrigo Torres Nascimento
Status: Merged
Merge reported by: David Callé
Merged at revision: not available
Proposed branch: lp://staging/~motoster/onehundredscopes/grooveshark-precise-simple_preview
Merge into: lp://staging/~davidc3/onehundredscopes/grooveshark-precise
Diff against target: 153 lines (+84/-26)
1 file modified
src/unity-scope-grooveshark (+84/-26)
To merge this branch: bzr merge lp://staging/~motoster/onehundredscopes/grooveshark-precise-simple_preview
Reviewer Review Type Date Requested Status
David Callé Pending
Review via email: mp+132007@code.staging.launchpad.net

Commit message

A simple preview implementation

Description of the change

This branch implements a simple preview for unity-scope-grooveshark.

The way grooveshark API works makes impossible to recover item details from SongID or AlbumID. That forced me to use a form of data storage.

The first parameter of model.append was used to store the entire item in a serialized form.

This is probably not the best approach. The best alternative may be apply for Grooveshark Public API access.

A good preview would show all tracks from an album, even if user previewed a track.

Feel free to refuse this merge if you don't agree with anything.

To post a comment you must log in.
Revision history for this message
Welton Rodrigo Torres Nascimento (motoster) wrote :

Hello,

I would like to continue working in this Grooveshark scope. Could you give me some hint or advice on what kind of preview it should have?

It would be possible to build a much better preview having access to the public API Grooveshark.

You ever requested such access?

Revision history for this message
David Callé (davidc3) wrote :

Hello!

I didn't had the time this week to review and eventually merge your
proposals (because I'm in Copenhagen for the UDS), so I'm probably going to
do that on monday.
I've requested access to the Grooveshark API, and it wasn't granted, a year
ago and 6 months ago, but I think I will try again next week. About
previews, I don't remember exactly but I think that the Grooveshark API
could provide actual song previews; the idea would be to get as close as
the current local music previews, as a first step, then maybe work on a
better design. I also know that the Unity Design team wants it to be
installed by default, so music previews will have to be quite consistent
between scopes.

Nevertheless, there is a new policy that won't allow Python scopes/lenses
installed by default (for obvious ram reasons, since Ubuntu wants to target
the mobile/tablet market), so it will be ported to Vala, or (hopefully) Go,
this cycle. But that's another story, and it still needs input from the
Ubuntu Desktop team...

On more thing on the Grooveshark API, if we get access, we will be able to
provide an Online Accounts plugin, to integrate Grooveshark favorites,
uploaded songs from the user account, etc. Which is quite exciting.

Thanks *a lot* for collaborating on this!

On Fri, Nov 2, 2012 at 4:19 PM, Welton Rodrigo Torres Nascimento <
<email address hidden>> wrote:

> Hello,
>
> I would like to continue working in this Grooveshark scope. Could you give
> me some hint or advice on what kind of preview it should have?
>
> It would be possible to build a much better preview having access to the
> public API Grooveshark.
>
> You ever requested such access?
>
> --
>
> https://code.launchpad.net/~motoster/onehundredscopes/grooveshark-precise-simple_preview/+merge/132007
> You are requested to review the proposed merge of
> lp:~motoster/onehundredscopes/grooveshark-precise-simple_preview into
> lp:~davidc3/onehundredscopes/grooveshark-precise.
>

Revision history for this message
David Callé (davidc3) wrote :

Oh, I've answered by mail and it wasn't supposed to land directly on this page but to be a personnal mail. Oh, well.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches