Bluez Utilities

Merge lp://staging/~morphis/bluez/fix-snapcraft-source into lp://staging/~bluetooth/bluez/snap-core-rolling

  1. fix-snapcraft-source
  2. Merge into snap-core-rolling
Proposed by Simon Fels
Status: Merged
Approved by: Simon Fels
Approved revision: 43
Merged at revision: 40
Proposed branch: lp://staging/~morphis/bluez/fix-snapcraft-source
Merge into: lp://staging/~bluetooth/bluez/snap-core-rolling
Diff against target: 123 lines (+52/-16)
2 files modified
parts/plugins/x-autotools.py (+45/-8)
snapcraft.yaml (+7/-8)
To merge this branch: bzr merge lp://staging/~morphis/bluez/fix-snapcraft-source
Reviewer Review Type Date Requested Status
Scott Sweeny (community) Approve
Tony Espy Pending
Bluetooth Pending
Review via email: mp+291757@code.staging.launchpad.net

Commit message

Fixes to get build working on launchpad

* Use same autotools plugin we use for network-manager
* Fetch source tarball over http as launchpad proxy can't deal with git://
* Adjust stage-packages/build-packages to be correct

Description of the change

See https://launchpad.net/~phablet-team/+snap/bluez for successful builds with this.

To post a comment you must log in.
Revision history for this message
Scott Sweeny (ssweeny) wrote :

snapcraft.yaml looks OK to me except for a deprecation warning about the icon definition. Instead of specifying it in the yaml file you put the icon file itself in setup/gui/[1]

[1] https://github.com/ubuntu-core/snapcraft/blob/master/docs/metadata.md#snap-icon

review: Needs Fixing
Revision history for this message
Scott Sweeny (ssweeny) wrote :

> snapcraft.yaml looks OK to me except for a deprecation warning about the icon
> definition. Instead of specifying it in the yaml file you put the icon file
> itself in setup/gui/[1]
>
> [1] https://github.com/ubuntu-core/snapcraft/blob/master/docs/metadata.md
> #snap-icon

... that should say "Instead of specifying it in the yaml file you *need to* put the icon file itself in setup/gui"

lp://staging/~morphis/bluez/fix-snapcraft-source updated
43. By Simon Fels

Move icon at the place it belongs to

Revision history for this message
Simon Fels (morphis) wrote :

@Scott: Fixed

Revision history for this message
Scott Sweeny (ssweeny) wrote :

This looks good now, and I've proposed my own branch on top of it.

https://code.launchpad.net/~ssweeny/bluez/snappy-interface/+merge/292304

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: