Merge lp://staging/~morphis/aethercast/add-urfkill-support2 into lp://staging/aethercast

Proposed by Simon Fels
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 165
Merged at revision: 150
Proposed branch: lp://staging/~morphis/aethercast/add-urfkill-support2
Merge into: lp://staging/aethercast
Prerequisite: lp://staging/~morphis/aethercast/fix-integraion-tests
Diff against target: 928 lines (+496/-182)
13 files modified
conf/aethercast.conf.in (+1/-1)
src/CMakeLists.txt (+2/-0)
src/ac/service.cpp (+21/-4)
src/ac/service.h (+2/-0)
src/w11tng/interfaceselector.cpp (+4/-0)
src/w11tng/kernelrfkillmanager.cpp (+143/-0)
src/w11tng/kernelrfkillmanager.h (+57/-0)
src/w11tng/networkmanager.cpp (+70/-20)
src/w11tng/networkmanager.h (+6/-0)
src/w11tng/rfkillmanager.cpp (+1/-125)
src/w11tng/rfkillmanager.h (+9/-32)
src/w11tng/urfkillmanager.cpp (+124/-0)
src/w11tng/urfkillmanager.h (+56/-0)
To merge this branch: bzr merge lp://staging/~morphis/aethercast/add-urfkill-support2
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Approve
Konrad Zapałowicz (community) code Approve
Thomas Voß (community) Needs Fixing
Review via email: mp+298498@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-06-28.

Commit message

Add URfkill support to manage kill switches on selected devices

Some devices don't use the rfkill provided from the kernel to managed the kill state of WiFi. They are using a libhardware_legacy from Android through libhybris to manage the WiFi power state. We have to use urfkill in those cases rather than relying on the rfkill provided from the kernel.

Fixes LP #1579676

This fixes in addition also problems with reporting the correct device state when it updates.

Description of the change

Add URfkill support to manage kill switches on selected devices

Some devices don't use the rfkill provided from the kernel to managed the kill state of WiFi. They are using a libhardware_legacy from Android through libhybris to manage the WiFi power state. We have to use urfkill in those cases rather than relying on the rfkill provided from the kernel.

To post a comment you must log in.
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

See comments below.

review: Needs Fixing
Revision history for this message
Thomas Voß (thomas-voss) wrote :

Minor niggles inline.

review: Needs Fixing
Revision history for this message
Simon Fels (morphis) :
158. By Simon Fels

Adjust for review comments and fix small bugs

159. By Simon Fels

Require urfkill being started before us

160. By Simon Fels

Always report changed device state to observer

161. By Simon Fels

Make sure we report the correct states for disconnected devices

Revision history for this message
Simon Fels (morphis) wrote :

Fixed review comments and fixed further problems with device state handling.

162. By Simon Fels

Fix a crash for the connect timeout

Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

A few questions regarding const-ness

review: Needs Information (code)
163. By Simon Fels

Drop unneeded upstart job change for selecting rfkill manager

164. By Simon Fels

Respect review comments

165. By Simon Fels

Don't change GO intent

Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

LGTM

review: Approve (code)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: