Python Fixtures

Merge lp://staging/~mordred/python-fixtures/agressive-loggers into lp://staging/~python-fixtures/python-fixtures/trunk

  1. agressive-loggers
  2. Merge into trunk
Proposed by Monty Taylor
Status: Needs review
Proposed branch: lp://staging/~mordred/python-fixtures/agressive-loggers
Merge into: lp://staging/~python-fixtures/python-fixtures/trunk
Diff against target: 48 lines (+18/-9)
1 file modified
lib/fixtures/_fixtures/logger.py (+18/-9)
To merge this branch: bzr merge lp://staging/~mordred/python-fixtures/agressive-loggers
Reviewer Review Type Date Requested Status
python-fixtures committers Pending
Review via email: mp+150237@code.staging.launchpad.net

Description of the change

In the case where Logger is instantiated with no arguments, what we want is to grab ALL of the logging that's out there. To that end, iterate through the loggerDict and take over anything that's found there too.

The idea came from the nosetests logcapture plugin after noticing that nose was capturing things that the logger fixture was not.

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

Could we please get a test that this saves/restores properly?

Also loggers are hierarchical, so we should be able to just replace
everything with a single logger.

Reply
Revision history for this message
Robert Collins (lifeless) wrote :

ping :)

Reply

Unmerged revisions

69. By Monty Taylor

Added missing import.

68. By Monty Taylor

Expand logic for handling the "grab everything" case.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches