DockManager

Merge lp://staging/~mnestor/dockmanager/pithos_control_helper into lp://staging/dockmanager

  1. pithos_control_helper
  2. Merge into trunk
Proposed by Mike Nestor
Status: Merged
Merged at revision: 66
Proposed branch: lp://staging/~mnestor/dockmanager/pithos_control_helper
Merge into: lp://staging/dockmanager
Diff against target: 237 lines (+227/-0)
2 files modified
metadata/pithos_control.py.info (+6/-0)
scripts/pithos_control.py (+221/-0)
To merge this branch: bzr merge lp://staging/~mnestor/dockmanager/pithos_control_helper
Reviewer Review Type Date Requested Status
Rico Tzschichholz Approve
Review via email: mp+34585@code.staging.launchpad.net

Description of the change

DONE: Add this to metadata/pithos_control.py.info
DBusName=net.kevinmehall.Pithos

DONE: Drop the ".svg" extension of the icon definitions

Not that I found: Isn't pithos installing an icon to /usr/share/icons ?

DONE: Remove debug lines

DONE: Use DOCKITEM_IFACE in dockmanager instead of "org.freedesktop.DockItem" which is deprecated and should be "net.launchpad.DockItem"

Added DBus listening for MediaPlayerKeyPressed so Helper can act on Play/Pause/Stop/Next/Previous multimedia key presses.

To post a comment you must log in.
lp://staging/~mnestor/dockmanager/pithos_control_helper updated
49. By Mike Nestor <mnestor@jarod>

Don't crash if can't connect to gnome.SettingsDaemon dbus

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Merged

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: