loggerhead

Merge lp://staging/~mkanat/loggerhead/launchpad into lp://staging/~launchpad-pqm/loggerhead/devel

  1. launchpad
  2. Merge into devel
Proposed by Max Kanat-Alexander
Status: Merged
Approved by: Brad Crittenden
Approved revision: 179
Merged at revision: 179
Proposed branch: lp://staging/~mkanat/loggerhead/launchpad
Merge into: lp://staging/~launchpad-pqm/loggerhead/devel
Diff against target: 27 lines (+8/-2)
1 file modified
loggerhead/controllers/__init__.py (+8/-2)
To merge this branch: bzr merge lp://staging/~mkanat/loggerhead/launchpad
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Launchpad PQM Bot Pending
Review via email: mp+46880@code.staging.launchpad.net

Commit message

[r=bac][bug=698305]

Description of the change

Fix bug 698305 for launchpad.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Thanks for making this change.

The code you modified looks good. Would you be able to exercise this change in the test_controllers unit test? I think it would be a great addition.

review: Needs Information (code)
Revision history for this message
Max Kanat-Alexander (mkanat) wrote :

Ah, that would be more relevant to request on the loggerhead trunk. This is just updating launchpad to use the code from there.

Revision history for this message
Brad Crittenden (bac) wrote :

Thanks Max.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches