Beautiful Soup

Merge lp://staging/~mjumbewu/beautifulsoup/text-white-space-fix into lp://staging/beautifulsoup/3.2

  1. text-white-space-fix
  2. Merge into 3.2
Proposed by Mjumbe Wawatu Ukweli
Status: Rejected
Rejected by: Leonard Richardson
Proposed branch: lp://staging/~mjumbewu/beautifulsoup/text-white-space-fix
Merge into: lp://staging/beautifulsoup/3.2
Diff against target: 39 lines (+13/-2)
2 files modified
BeautifulSoup.py (+3/-2)
BeautifulSoupTests.py (+10/-0)
To merge this branch: bzr merge lp://staging/~mjumbewu/beautifulsoup/text-white-space-fix
Reviewer Review Type Date Requested Status
Leonard Richardson Disapprove
Review via email: mp+62629@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-05-27.

Description of the change

BeautifulSoup removes too much white space on getText. For example, the text of "<p>This is a <i>test</i>, ok?" should be "This is a test, ok?". Instead, BS calculates it as "This is atest, ok?"

This invalidates bug #788986

To post a comment you must log in.
Revision history for this message
Leonard Richardson (leonardr) wrote :

Bug 788986 was fixed another way.

review: Disapprove

Unmerged revisions

45. By Mjumbe Wawatu Ukweli

In getText, multiple white space characters get truncated to one.

44. By Mjumbe Wawatu Ukweli

Preserve spacing when using getText.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches