libappindicator

Merge lp://staging/~mitya57/libappindicator/test-simple-app into lp://staging/libappindicator/16.10

  1. test-simple-app
  2. Merge into trunk.16.10
Proposed by Dmitry Shachnev
Status: Merged
Merged at revision: 274
Proposed branch: lp://staging/~mitya57/libappindicator/test-simple-app
Merge into: lp://staging/libappindicator/16.10
Diff against target: 48 lines (+12/-12)
1 file modified
tests/test-simple-app.c (+12/-12)
To merge this branch: bzr merge lp://staging/~mitya57/libappindicator/test-simple-app
Reviewer Review Type Date Requested Status
Alberts Muktupāvels Approve
Ted Gould Pending
Review via email: mp+304948@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-06-27.

Commit message

Make test-simple-app really working.

Description of the change

The previous version of the simple test application was crashing with SIGSEGV in g_object_new call. This one seems to actually work.

To post a comment you must log in.
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote : Posted in a previous version of this proposal

I probably would use gtk_menu_shell_append not gtk_menu_attach, but that should not be problem.

Code looks good, but I did not test it.

review: Approve
Revision history for this message
Dmitry Shachnev (mitya57) wrote : Posted in a previous version of this proposal

gtk_menu_shell_append is of course better, updated

Revision history for this message
Ted Gould (ted) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Alberts Muktupāvels (muktupavels) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches