Merge lp://staging/~mir-team/mir/fix-initial-key-repeat-timeout into lp://staging/mir
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Chris Halse Rogers | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 2732 | ||||
| Proposed branch: | lp://staging/~mir-team/mir/fix-initial-key-repeat-timeout | ||||
| Merge into: | lp://staging/mir | ||||
| Diff against target: |
105 lines (+16/-10) 4 files modified
src/server/input/default_configuration.cpp (+3/-2) src/server/input/key_repeat_dispatcher.cpp (+5/-3) src/server/input/key_repeat_dispatcher.h (+3/-1) tests/unit-tests/input/test_key_repeat_dispatcher.cpp (+5/-4) |
||||
| To merge this branch: | bzr merge lp://staging/~mir-team/mir/fix-initial-key-repeat-timeout | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Chris Halse Rogers | Approve | ||
| Alberto Aguirre (community) | Approve | ||
|
Review via email:
|
|||
Commit message
A single timeout isn't enough for reasonable key repeat behavior. We need a longer delay before sending the FIRST repeat or keys will start repeating too quickly. I observed this issue in autopilot.
This branch implements such a timeout.
This also bumps the key repeat delay (the time inbetween repeats once they are being sent) to 50ms, or the same value as in the old InputDispatcher
Description of the change
A single timeout isn't enough for reasonable key repeat behavior. We need a longer delay before sending the FIRST repeat or keys will start repeating too quickly. I observed this issue in autopilot.
This branch implements such a timeout.
This also bumps the key repeat delay (the time inbetween repeats once they are being sent) to 50ms, or the same value as in the old InputDispatcher
| PS Jenkins bot (ps-jenkins) wrote | # |
OK.