OpenERP Community Backports (Addons)

Merge lp://staging/~mileo/ocb-addons/70-bug-1201472 into lp://staging/ocb-addons

Proposed by Luis Felipe Miléo - http://www.kmee.com.br on 2014-02-28

Status:	Merged
Approved by:	Holger Brunn (Therp) on 2014-03-10
Approved revision:	no longer in the source branch.
Merged at revision:	10012
Proposed branch:	lp://staging/~mileo/ocb-addons/70-bug-1201472
Merge into:	lp://staging/ocb-addons
Diff against target:	41 lines (+8/-8) 1 file modified l10n_br/account_view.xml (+8/-8)
To merge this branch:	bzr merge lp://staging/~mileo/ocb-addons/70-bug-1201472
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Raphaël Valyi - http://www.akretion.com		2014-02-28	Approve on 2014-03-10
Holger Brunn (Therp)			Approve on 2014-03-10
Guewen Baconnier @ Camptocamp			Approve on 2014-02-28
Stefan Rijnhart (Opener)			Approve on 2014-02-28
Pedro Manuel Baeza	code review		Approve on 2014-02-28
Review via email: mp+208722@code.staging.launchpad.net

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-02-28:

LGTM

Still with pieces of group_extended issues... uff

Regards.

review: Approve (code review)

Revision history for this message

Stefan Rijnhart (Opener) (stefan-opener) wrote on 2014-02-28:

LGTM

review: Approve

Revision history for this message

Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote on 2014-02-28:

LGTM

review: Approve

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2014-02-28:

Thanks for spotting this one Luis! And welcome to to free world!

review: Approve

Revision history for this message

Holger Brunn (Therp) (hbrunn) wrote on 2014-03-03:

review: Needs Fixing (code review)

Revision history for this message

Luis Felipe Miléo - http://www.kmee.com.br (mileo) wrote on 2014-03-07:

> The patch for trunk uses group_no_one (Technical features), which seems
> correct to me: https://code.launchpad.net/~openerp-dev/openobject-addons
> /trunk-bug-1201472-cod/+merge/194657

The patch don't works well:

Personally I think this type of functionality should not be hidden in a group. They are decisive for Brazilian companies wishing to use openerp.

Revision history for this message

Holger Brunn (Therp) (hbrunn) wrote on 2014-03-10:

Okay, makes sense

review: Approve

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2014-03-10:

Hello, I also think Luis is right not asking additional tech group to see these fields.

review: Approve