unity-scope-click

Merge lp://staging/~mikemc/unity-scope-click/cxx-dlmgr-add-tool into lp://staging/unity-scope-click

cxx-dlmgr-add-tool
Merge into trunk

Proposed by Mike McCracken on 2014-01-21

Status:	Merged
Approved by:	dobey on 2014-01-24
Approved revision:	118
Merged at revision:	116
Proposed branch:	lp://staging/~mikemc/unity-scope-click/cxx-dlmgr-add-tool
Merge into:	lp://staging/unity-scope-click
Prerequisite:	lp://staging/~mikemc/unity-scope-click/cxx-dlmgr-more-tests
Diff against target:	174 lines (+150/-0) 4 files modified scope/tests/CMakeLists.txt (+1/-0) scope/tests/download_manager_tool/CMakeLists.txt (+11/-0) scope/tests/download_manager_tool/download_manager_tool.cpp (+79/-0) scope/tests/download_manager_tool/download_manager_tool.h (+59/-0)
To merge this branch:	bzr merge lp://staging/~mikemc/unity-scope-click/cxx-dlmgr-add-tool
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration	2014-01-21	Approve on 2014-01-24
Diego Sarmentero (community)			Approve on 2014-01-24
Manuel de la Peña (community)		2014-01-21	Approve on 2014-01-24
Review via email: mp+202570@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-01-21.

Commit message

- Add CLI tool for getting the click token from a store URL using download manager, for IRL testing.

Description of the change

- Add CLI tool for getting the click token from a store URL using download manager, for IRL testing.

usage:

U1_DEBUG=1 $builddir/scope/tests/download_manager_tool/download_manager_tool https://public.apps.ubuntu.com/download/com.ubuntu.developer.mzanetti/fahrplan2/com.ubuntu.developer.mzanetti.fahrplan2_2.0.14.1_unknown.click

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-21: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:117
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/184/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-amd64-ci/82
FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-armhf-ci/82/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/184/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-21:

FAILED: Continuous integration, rev:117
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mikemc/unity-scope-click/cxx-dlmgr-add-tool/+merge/202570/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/185/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-amd64-ci/83
FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-armhf-ci/83/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/185/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Manuel de la Peña (mandel) wrote on 2014-01-22:

A small thing, please use explicit for the single argument constructors and maybe always set the QObject* parent parameter to be optional, for example:

explicit DownloadManagerTool(QObject *parent=0);

review: Needs Fixing

lp://staging/~mikemc/unity-scope-click/cxx-dlmgr-add-tool updated on 2014-01-24

113. By Alejandro J. Cura on 2014-01-22

A webclient that uses Qt, and the scaffolding for unit and integration tests.

Approved by Manuel de la Peña, Rodney Dawes, PS Jenkins bot.

114. By Leo Arias on 2014-01-23