Merge lp://staging/~mikemc/ubuntuone-ios-files/quiet-crashlytics into lp://staging/ubuntuone-ios-files
Proposed by
Mike McCracken
| Status: | Merged |
|---|---|
| Approved by: | dobey |
| Approved revision: | 101 |
| Merged at revision: | 101 |
| Proposed branch: | lp://staging/~mikemc/ubuntuone-ios-files/quiet-crashlytics |
| Merge into: | lp://staging/ubuntuone-ios-files |
| Diff against target: |
308 lines (+57/-27) 15 files modified
Files/FilesAppDelegate.m (+2/-2) Files/U1AssetManager.m (+1/-1) Files/U1AutoUploadOperation.m (+2/-2) Files/U1AutoUploadsManager.m (+2/-2) Files/U1DataRepository.m (+2/-2) Files/U1FileDetailsViewController.m (+2/-2) Files/U1FilesClient.m (+3/-2) Files/U1FilesService.m (+2/-2) Files/U1FolderViewController.m (+2/-2) Files/U1Logging.h (+28/-0) Files/U1SettingsViewController.m (+3/-2) Files/U1SingleSignOnProvider.m (+2/-2) Files/U1UploadOperation.m (+2/-2) Files/U1UploadsPoolViewController.m (+2/-2) Files/U1VolumesViewController.m (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~mikemc/ubuntuone-ios-files/quiet-crashlytics |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2013-05-20.
Commit message
- Avoid sending logs to crashlytics from debug builds.
Description of the change
- avoid sending logs to crashlytics from debug builds
Wraps Crashlytics.h with a header file that redefines CLS_LOG so we don't waste time sending log info to crashlytics servers while running debug builds. Having that extra network activity also complicates debugging.
To post a comment you must log in.
Revision history for this message
| Mike McCracken (mikemc) wrote | # |
Revision history for this message
| dobey (dobey) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
6 -// Copyright 2011 Canonical Ltd.
7 +// Copyright 2013 Canonical Ltd.
These should be 2011-2013, not a simple change of the year.