Merge lp://staging/~mikemc/ubuntuone-ios-files/asset-library-sweep-refactor into lp://staging/ubuntuone-ios-files
Proposed by
Mike McCracken
| Status: | Merged |
|---|---|
| Approved by: | dobey |
| Approved revision: | 98 |
| Merged at revision: | 100 |
| Proposed branch: | lp://staging/~mikemc/ubuntuone-ios-files/asset-library-sweep-refactor |
| Merge into: | lp://staging/ubuntuone-ios-files |
| Diff against target: |
869 lines (+413/-279) 6 files modified
Files/U1AssetManager.h (+32/-0) Files/U1AssetManager.m (+226/-0) Files/U1AutoUploadOperation.m (+2/-2) Files/U1AutoUploadsManager.h (+2/-3) Files/U1AutoUploadsManager.m (+147/-271) Files/U1FolderViewController.m (+4/-3) |
| To merge this branch: | bzr merge lp://staging/~mikemc/ubuntuone-ios-files/asset-library-sweep-refactor |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- refactor sweep of asset library into separate manager
Description of the change
- refactor sweep of asset library into separate manager
- intended to support future use of sweep code for hashing and searching assets without queueing uploads
- remove now-unused filename generation dating from before iOS 5
- avoid multiple asset scans due to registering for LibraryChangedN
- avoid overly frequent scans of upload operation queue to generate pending upload badge, using a coalescing notification queue
To post a comment you must log in.
Revision history for this message
| dobey (dobey) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Do the pre-existing modified source files here, already have their copyright header updated to include 2013?